Added VIA compatible rules for Duck Octagon V2 PCB #9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added keymap and rules to allow VIA compatibility
zvecr
requested changes
Jul 9, 2020
zvecr
requested changes
Jul 9, 2020
Co-authored-by: Joel Challis <[email protected]>
zvecr
approved these changes
Jul 9, 2020
fauxpark
requested changes
Jul 10, 2020
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
fauxpark
approved these changes
Jul 10, 2020
zvecr
approved these changes
Jul 10, 2020
|
Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added VIA rules based on mechmerlin's original QMK port for the Octagon v2 PCB. Can be used for both Duck Octagon v2 and v3.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Hope This complies with the requirements, it has been tested with my own Duck Octagon v2 PCB that came with my Octagon v3. Also have designed the corresponding VIA JSON definition for a PR to be submitted on VIA.