Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce peak LED brightness for AoS TKL #9667

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Reduce peak LED brightness for AoS TKL #9667

merged 1 commit into from
Jul 8, 2020

Conversation

rys
Copy link
Contributor

@rys rys commented Jul 6, 2020

Description

One line config.h change to limit the maximum LED brightness value to 50, to better suit the LED setup on the board. Tested on a pre-production PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 7, 2020 15:17
@Erovia Erovia merged commit 4588c97 into qmk:master Jul 8, 2020
@rys rys deleted the aos-tkl-lighting-fix branch July 18, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rys @Erovia @fauxpark