Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA Functionality for Keyhive Maypad #9654

Merged
merged 9 commits into from
Jul 8, 2020
Merged

Add VIA Functionality for Keyhive Maypad #9654

merged 9 commits into from
Jul 8, 2020

Conversation

dot-hex
Copy link
Contributor

@dot-hex dot-hex commented Jul 5, 2020 •
edited
Loading

Description

Added VIA Functionality for Keyhive Maypad

Added VIA functionality for the Maypad. This keymap is for the Ortho_5x4 layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dot-hex added 4 commits July 4, 2020 22:20
@dot-hex
Added VIA functionality for Maypad
76c6360 
Added VIA functionality
@dot-hex
Updated readme.md
1694c67
@dot-hex
Update readme.md
427b7f1
@dot-hex
Update keymap.c
57231a1 
Removed comma causing error when trying to compile.
fauxpark
fauxpark requested changes Jul 5, 2020
View reviewed changes
keyboards/keyhive/maypad/config.h Outdated Show resolved Hide resolved
keyboards/keyhive/maypad/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/keyhive/maypad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/keyhive/maypad/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark added keymap via Adds via keymap and/or updates keyboard for via support labels Jul 5, 2020
@fauxpark fauxpark requested a review from a team July 5, 2020 06:05
dot-hex and others added 4 commits July 4, 2020 23:06
@dot-hex @fauxpark
Update keyboards/keyhive/maypad/config.h
36e63b0 
Change product_ID to value for MP

Co-authored-by: Ryan <[email protected]>
@dot-hex
Update config.h
6f401bc 
Removed copyright as part of line 1 per suggestion.
@dot-hex @fauxpark
Update keyboards/keyhive/maypad/keymaps/via/keymap.c
5a1aac9 
Update VIA Layout to match the default layout.

Co-authored-by: Ryan <[email protected]>
@dot-hex @fauxpark
Update keyboards/keyhive/maypad/keymaps/via/rules.mk
08d9578 
Remove extra options that are not required.

Co-authored-by: Ryan <[email protected]>
@dot-hex
Delete config.h
e55a386 
Removed config.h from keymaps/via folder by suggestion.
@fauxpark fauxpark requested a review from a team July 5, 2020 06:16
@dot-hex dot-hex marked this pull request as ready for review July 5, 2020 06:17
@dot-hex
Copy link
Contributor Author

dot-hex commented Jul 5, 2020

Thank you so much for all of your help so far, @fauxpark.

This is my first attempt at a contribution, I appreciate all the help I can get!

@dot-hex dot-hex mentioned this pull request Jul 5, 2020
Merged
6 tasks
@Erovia Erovia merged commit c4960b7 into qmk:master Jul 8, 2020
@Erovia
Copy link
Member

Erovia commented Jul 8, 2020

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dot-hex @Erovia @fauxpark