Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keymap] Add VIA support for Hub16 #9638

Merged
merged 6 commits into from
Jul 17, 2020
Merged

[keymap] Add VIA support for Hub16 #9638

merged 6 commits into from
Jul 17, 2020

Conversation

joshajohnson
Copy link
Contributor

Description

  • Add VIA support for Hub16
  • Fix bug where encoder button would not continually send key when held.
    • I tried using custom_matrix=lite for the matrix scanning code but couldn't get it working, so apologies for the overhead.

Thanks in advance :)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@joshajohnson joshajohnson mentioned this pull request Jul 3, 2020
Merged
6 tasks
fauxpark
fauxpark requested changes Jul 3, 2020
View reviewed changes
keyboards/hub16/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 3, 2020
@joshajohnson joshajohnson requested a review from fauxpark July 14, 2020 08:11
@zvecr zvecr merged commit 07a817d into qmk:master Jul 17, 2020
@zvecr
Copy link
Member

zvecr commented Jul 17, 2020

Thanks!

@joshajohnson joshajohnson deleted the via branch September 7, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshajohnson @zvecr @fauxpark