Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] Add rartpad #9614

Merged
merged 20 commits into from
Jul 11, 2020
Merged

[keyboard] Add rartpad #9614

merged 20 commits into from
Jul 11, 2020

Conversation

ladbahuy
Copy link
Contributor

@ladbahuy ladbahuy commented Jul 1, 2020 •
edited
Loading

Description

re-add new keyboard rartpad from #9410

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jul 3, 2020
View reviewed changes
keyboards/rart/rartpad/ratpad.h Outdated Show resolved Hide resolved
keyboards/rart/rartpad/ratpad.c Outdated Show resolved Hide resolved
@zvecr zvecr changed the title [keyboard] re-add rartpad [keyboard] Add rartpad Jul 3, 2020
@zvecr zvecr requested a review from a team July 3, 2020 22:25
@zvecr zvecr added the keyboard label Jul 3, 2020
Erovia
Erovia requested changes Jul 4, 2020
View reviewed changes
keyboards/rart/rartpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rart/rartpad/keymaps/numpad/keymap.c Outdated Show resolved Hide resolved
keyboards/rart/rartpad/rartpad.h Outdated Show resolved Hide resolved
keyboards/rart/rartpad/readme.md Show resolved Hide resolved
@Erovia Erovia requested review from zvecr and a team July 4, 2020 15:00
@ladbahuy
Copy link
Contributor Author

ladbahuy commented Jul 9, 2020

hay @zvecr, can it be approved?

fauxpark
fauxpark requested changes Jul 9, 2020
View reviewed changes
keyboards/rart/rartpad/keymaps/numpad/keymap.c Outdated Show resolved Hide resolved
keyboards/rart/rartpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rart/rartpad/config.h Outdated Show resolved Hide resolved
keyboards/rart/rartpad/config.h Outdated Show resolved Hide resolved
@Erovia Erovia requested a review from fauxpark July 9, 2020 19:25
@ladbahuy
Copy link
Contributor Author

ladbahuy commented Jul 9, 2020

hay @fauxpark , can it be approved?

fauxpark
fauxpark requested changes Jul 10, 2020
View reviewed changes
keyboards/rart/rartpad/info.json Outdated Show resolved Hide resolved
@ladbahuy
Copy link
Contributor Author

@Erovia can it be merged?

@Erovia Erovia merged commit 6609197 into qmk:master Jul 11, 2020
@Erovia
Copy link
Member

Erovia commented Jul 11, 2020

Yep.
Thank you for your contribution.

@ladbahuy
Copy link
Contributor Author

yup, thanks before @Erovia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ladbahuy @Erovia @fauxpark @zvecr