Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL path not always starting with /mnt #9594

Closed
wants to merge 2 commits into from

Conversation

MrMarble
Copy link

@MrMarble MrMarble commented Jun 30, 2020

Description

The windows filesystem inside wsl is not always mounted on /mnt, as it can be changed by the user. see the key root on the automount section in the wsl docs

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 5, 2020 03:45
@drashna drashna added the bug label Jul 5, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this script's mode was changed from 755 to 644 (i.e. no longer executable) -- that'll need to be fixed too.

util/wsl_install.sh Outdated Show resolved Hide resolved
@stale stale bot removed the awaiting changes label Aug 22, 2020
@tzarc tzarc requested a review from a team August 22, 2020 11:47
Co-authored-by: Nick Brassel <[email protected]>
@stale
Copy link

stale bot commented Oct 7, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna self-requested a review October 11, 2020 00:29
@stale stale bot removed the awaiting changes label Oct 11, 2020
@fauxpark
Copy link
Member

Thanks for your contribution!

I'm closing this PR as it has been rendered obsolete by the removal of wsl_install.sh in #10593 - installation under WSL is now treated as a normal Linux install, with a notice at the end that you should install the QMK Toolbox and map the WSL filesystem to a network drive in order to flash. This is hopefully a temporary measure, until WSL gets proper USB support.

@fauxpark fauxpark closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants