Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alter Keyboard #9579

Merged
merged 12 commits into from
Jul 17, 2020
Merged

Add Alter Keyboard #9579

merged 12 commits into from
Jul 17, 2020

Conversation

DeskDaily
Copy link
Contributor

@DeskDaily DeskDaily commented Jun 29, 2020 •
edited
Loading

Add Alter, an Alice layout keyboard

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jul 3, 2020
View reviewed changes
keyboards/nightly_boards/alter/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/nightly_boards/alter/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/nightly_boards/alter/rev1/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jul 3, 2020
@zvecr zvecr requested a review from a team July 3, 2020 20:37
fauxpark
fauxpark requested changes Jul 4, 2020
View reviewed changes
keyboards/nightly_boards/alter/rev1/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/nightly_boards/alter/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nightly_boards/alter/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/nightly_boards/alter/rev1/rules.mk Outdated Show resolved Hide resolved
@DeskDaily
Copy link
Contributor Author

Files are updated based on the comments

@drashna drashna requested a review from a team July 8, 2020 13:23
@zvecr
Copy link
Member

zvecr commented Jul 17, 2020

Thanks!

@zvecr zvecr merged commit 412c6bf into qmk:master Jul 17, 2020
@DeskDaily DeskDaily deleted the alter branch August 6, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeskDaily @zvecr @drashna @fauxpark