Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/documentation_best_practices.md #9522

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jun 23, 2020

Description

Add a Japanese translation of docs/documentation_best_practices.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jun 24, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team June 25, 2020 08:44
@mtei mtei requested a review from a team June 25, 2020 12:07
@mtei
Copy link
Contributor

mtei commented Jun 25, 2020

I think this is ready to merge.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me here besides the following:

docs/ja/documentation_best_practices.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from noroadsleft June 26, 2020 09:45
@noroadsleft noroadsleft merged commit 6574ac5 into qmk:master Jun 28, 2020
@noroadsleft
Copy link
Member

ありがとうございました!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
…mk#9522)

* add documentation_best_practices.md translation

* update based on comment

* update based on comment
@umi-umi umi-umi deleted the documentation_best_practices.md-japanese-translation branch July 10, 2020 16:39
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
…mk#9522)

* add documentation_best_practices.md translation

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants