-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Japanese translation of docs/documentation_best_practices.md #9522
Merged
noroadsleft
merged 3 commits into
qmk:master
from
umi-umi:documentation_best_practices.md-japanese-translation
Jun 28, 2020
Merged
[Docs] Japanese translation of docs/documentation_best_practices.md #9522
noroadsleft
merged 3 commits into
qmk:master
from
umi-umi:documentation_best_practices.md-japanese-translation
Jun 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。 |
shelaf
reviewed
Jun 25, 2020
mtei
reviewed
Jun 25, 2020
mtei
approved these changes
Jun 25, 2020
shelaf
approved these changes
Jun 25, 2020
I think this is ready to merge. |
noroadsleft
requested changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me here besides the following:
mtei
approved these changes
Jun 26, 2020
shelaf
approved these changes
Jun 26, 2020
noroadsleft
approved these changes
Jun 28, 2020
ありがとうございました! |
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
…mk#9522) * add documentation_best_practices.md translation * update based on comment * update based on comment
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…mk#9522) * add documentation_best_practices.md translation * update based on comment * update based on comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Japanese translation of docs/documentation_best_practices.md.
Types of Changes
Issues Fixed or Closed by This PR
Checklist