Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error_log complaint about Big Series boards #9510

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix error_log complaint about Big Series boards #9510

merged 1 commit into from
Jun 23, 2020

Conversation

fauxpark
Copy link
Member

Description

"Warning: bigseries: Falling back to searching for KEYMAP/LAYOUT macros."

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 23, 2020 02:08
Erovia
Erovia approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should come up with a better solution instead of requiring dummy or 1:1 copy rules.mks for every revision.

@Erovia Erovia merged commit aea2d68 into qmk:master Jun 23, 2020
@fauxpark fauxpark deleted the fix-bigseries-error branch June 23, 2020 08:40
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@fauxpark @jakobaa
Fix error_log complaint about Big Series boards (qmk#9510)
67eb126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @Erovia