Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing RGB controls on layer 1. #9481

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Added missing RGB controls on layer 1. #9481

merged 1 commit into from
Jun 20, 2020

Conversation

siano
Copy link
Contributor

@siano siano commented Jun 20, 2020

RGB Controls was missing. I've added them.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team June 20, 2020 21:15
@zvecr zvecr added the keymap label Jun 20, 2020
@Erovia Erovia merged commit d7f9e6f into qmk:master Jun 20, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@siano @jakobaa
Added missing RGB controls on layer 1. (qmk#9481)
1ad0103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siano @Erovia @zvecr