Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create maja info json #9472

Merged
merged 3 commits into from
Jun 23, 2020
Merged

create maja info json #9472

merged 3 commits into from
Jun 23, 2020

Conversation

moyi4681
Copy link
Contributor

@moyi4681 moyi4681 commented Jun 19, 2020 •
edited by zvecr
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from noroadsleft and a team June 20, 2020 21:24
@zvecr zvecr added the keyboard label Jun 20, 2020
zvecr
zvecr requested changes Jun 20, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading this into configurator with ctrl+shift+i produces,
image

@moyi4681
Copy link
Contributor Author

Loading this into configurator with ctrl+shift+i produces,
image

http://www.keyboard-layout-editor.com/#/gists/1076149e7b201b4dee024fa111452c20
how dow I import lthis layout?

@fauxpark
Copy link
Member

The info.json format (and thus qmk.fm/converter) currently does not support rotated keys. You'll need to modify the KLE to remove the rotation first.

@moyi4681 moyi4681 requested a review from zvecr June 23, 2020 06:13
@Erovia Erovia merged commit a502ce4 into qmk:master Jun 23, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@moyi4681 @jakobaa
create maja info json (qmk#9472)
c19f1e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moyi4681 @fauxpark @Erovia @zvecr