Allowing Pressing the Start Buttons Again to Stop Dynamic Macro Recording #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jun 18, 2020
fauxpark
approved these changes
Jun 19, 2020
This reverts commit 0595d93.
Erovia
approved these changes
Jul 7, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 9, 2020
…ding (qmk#9446) format code according to conventions [skip ci]
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows a user to press the start button again to stop recording dynamic macro. Previously, a seperate stop button has to be used. However, it's natural to press the start button again instead of using anothor button (which also takes additonal space on the keymap). Please note that the stop button is not disabled, so it should not break anything.
Types of Changes
Issues Fixed or Closed by This PR
Checklist