Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NKRO on 1up's boards #9434

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Enable NKRO on 1up's boards #9434

merged 2 commits into from
Jun 21, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Jun 16, 2020

Description

1up has asked me to make sure NKRO is enabled on their boards, while I was at it, I decided to make sure Bootmagic was consistently set to lite.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin changed the title Enable NKRO on two of 1up's boards Enable NKRO on 1up's boards Jun 16, 2020
@drashna drashna requested a review from a team June 18, 2020 06:09
@zvecr zvecr merged commit cb13dd0 into qmk:master Jun 21, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* enable NKRO and keep consistent with bootmagic set to lite

* Update keyboards/1upkeyboards/1up60hse/rules.mk

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
@mechmerlin mechmerlin deleted the feature/1up_nkro branch January 26, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants