Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user keymaps for ergodox_ez/dvorak_42_key / atreus/dvorak_42_key #9429

Merged
merged 6 commits into from
Jun 22, 2020
Merged

user keymaps for ergodox_ez/dvorak_42_key / atreus/dvorak_42_key #9429

merged 6 commits into from
Jun 22, 2020

Conversation

luc-vocab
Copy link
Contributor

@luc-vocab luc-vocab commented Jun 16, 2020 •
edited
Loading

Description

user keymap changes for ergodox_ez/dvorak_42_key / atreus/dvorak_42_key
add windows 10 workspace shortcuts, add vscode shortcuts, remove Cloud9 shortucts.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@luc-vocab
Copy link
Contributor Author

Hi @drashna , I accepted your changes, would it be possible to merge this PR ? Thank you.

@zvecr zvecr requested a review from drashna June 20, 2020 22:11
@zvecr zvecr added the keymap label Jun 20, 2020
@zvecr zvecr requested a review from a team June 20, 2020 22:11
fauxpark
fauxpark requested changes Jun 21, 2020
View reviewed changes
keyboards/atreus/keymaps/dvorak_42_key/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/dvorak_42_key/keymap.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team June 21, 2020 05:26
Erovia
Erovia approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check out the Userspace feature to reduce code duplication.

@Erovia Erovia merged commit 4b13c49 into qmk:master Jun 22, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@luc-vocab @drashna
@fauxpark @jakobaa
user keymaps for ergodox_ez/dvorak_42_key / atreus/dvorak_42_key (qmk…
5153735 
…#9429)

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luc-vocab @drashna @Erovia @fauxpark @zvecr