Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom keymaps #9426

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Adding custom keymaps #9426

merged 2 commits into from
Jun 26, 2020

Conversation

adamdehaven
Copy link
Contributor

Description

Adds custom keymaps for kbdfans75v2 and kbdfans67mkii

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 25, 2020 06:35
adamdehaven
adamdehaven commented Jun 25, 2020
View reviewed changes
Copy link
Contributor Author

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

noroadsleft
noroadsleft approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 9236c3a into qmk:master Jun 26, 2020
@noroadsleft
Copy link
Member

Thanks!

@adamdehaven adamdehaven deleted the custom_keymaps branch June 26, 2020 17:49
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@adamdehaven @jakobaa
[Keymap] Adding custom keymaps (qmk#9426)
6737ba3 
* Adding custom keymaps

* Update keyboards/kbdfans/kbd75/keymaps/adamdehaven/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdehaven @noroadsleft @fauxpark