-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Refactor JJ50 keyboard mapping to current standard #9415
Conversation
804c4b9
to
83aab09
Compare
With the changes to the |
I can't delete the rules.mk for the
|
Ah, well you can delete everything else then. |
The CI is having a hard time with xvzver, returning |
|
4882d77
to
5ea4c7b
Compare
My latest commit adapt a bit the workflow... I'm not sure if there is any blockers by changing the order? Can we talk somewhere else in order to chat about the subject? (discord irc slack...) |
Interesting that that seems to work, considering mcu_selection.mk first needs to know what The QMK Discord is linked in the readme (it's one of the badges) but I'll post it here too: https://discord.gg/Uq7gcHh |
the CI is going well indeed 😊 |
Well you've now added a core change to this PR so Travis is going to run |
I made the PR #9419 |
1a287b1
to
5ea4c7b
Compare
080e964
to
7f87e56
Compare
0e432c5
to
9eecbf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor fixes.
0d19931
to
abcb756
Compare
abcb756
to
bb49b5d
Compare
2b4b72f
to
adbb345
Compare
adbb345
to
9cebf12
Compare
Tested and it works like a charm :) |
I justed tested it and everything seems to work like it should! |
Description
Dvroak
,Colemak
as base layersAdjust
layer to change the base layerFn
mapping to have all rgblight and backlight featuresTypes of Changes
Checklist