Add flipped and discrete encoder support to PlaidPad default mappings #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will leave this as a draft until I get feedback from @BenRoe, no rush though. |
BenRoe
suggested changes
Jun 13, 2020
|
addressed typo and leaving the encoder rotation for now based on our chat. ccw -> left/down |
drashna
approved these changes
Jun 18, 2020
|
@matthewweldon please add the changes in the config.h from here to this pr. |
done, @BenRoe, I think this is ready to merge, going to make a new branch for the next keymap later |
|
Are there some questions about this pr, or is something missing? Please merge it. |
fauxpark
reviewed
Jul 14, 2020
fauxpark
approved these changes
Jul 21, 2020
drashna
approved these changes
Jul 24, 2020
|
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* Add flipped and discrete encoder support default mappings * Fixed typo in readme * Removed flipped layout, fix config.h encoder pin mapping, update readme Co-authored-by: matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default mapping for the keycapsss plaid pad 4x4 does not include support for different keypresses on the rotary encoders, and doesn't work for encoder hardware that have flipped orientations.
These changes address those issues by adding a new flipped layout and adding left/right arrows to the left encoder.
@BenRoe should approve this PR before merge
Description
This PR provides two changes.
The
defaultplaid pad mapping will have left/right arrows mapped to the left encoder, and keeps up/down arrows mapped to the right encoder. Keymapreadme.mdupdated to reflect this change.A new keymap is added for the plaid pad called
default_flippedwhich adds the flipped encoder support to the config.h file and also keeps the arrow changes from the first change. Keymapreadme.mdadded for explaining its usage.Types of Changes
Checklist