Adding encoder-enabled Lily58 keymap

[filoxo]

There is an unofficial hardware variant of the Lily58 that supports a rotary encoder. Keyhive is one vendor that supplies them: https://keyhive.xyz/shop/lily58

Description

This change adds a keymap based on the default one that enables encoder support. I initially wanted to make it a separate rev (as recommended in #8900) but couldn't make any sense of the build errors. I'd be happy to move stuff around but I'm more interested in just making it work.

I tested this with the current master of qmk on a Lily58, with the rotary encoder on the left side.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

This shouldn't be needed anymore, as there are functions to check all of the rgb config settings, and to write to them.

[filoxo]

I never responded to this. I don't think I'll be making that change since it would require touching all the keymaps and changing how the value is read in lib/rgb_state_reader.c, and that is enough effort to warrant a separate PR.

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[fauxpark]

Suggested change

	#ifdef PROTOCOL_LUFA
	#include "lufa.h"
	#include "split_util.h"
	#endif
	#ifdef SSD1306OLED
	#include "ssd1306.h"
	#endif

Fairly sure this block isn't needed.

[filoxo]

It's in the original default keymap. If it should be removed from there, then I feel like that should be batched into a separate PR instead of in this one.

[drashna]

It should be removed there, as well, but that would be a separate PR, ideally.

As in, for all the default keymaps that do this.

However, replicating the "bad code" should be avoided, as well.

[filoxo]

I'm going to go ahead and close this since I keep getting feedback for changes that aren't directly related to this keymap, and I'm frustrated with the gatekeeping needed for just a layout with additional options enabled.