Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KBO-5000 keyboard #9381

Merged
merged 8 commits into from
Jun 23, 2020
Merged

Add KBO-5000 keyboard #9381

merged 8 commits into from
Jun 23, 2020

Conversation

nooges
Copy link
Member

@nooges nooges commented Jun 11, 2020

Description

Adds KBO-5000 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 15, 2020 09:57
noroadsleft
noroadsleft approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 3028662 into qmk:master Jun 23, 2020
@noroadsleft
Copy link
Member

Thanks!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@nooges @jakobaa
[Keyboard] Add KBO-5000 keyboard (qmk#9381)
db05b73 
* Initial fork of Sinc

* Setup keymaps, layouts, and encoders

* Add ANSI configurator layout

* Add ISO layout for configurator

* Add all layout option for configurator

* Fix spacing

* Remove extra line

* Remove unneeded ifdef
@nooges nooges mentioned this pull request Jun 9, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nooges @noroadsleft @drashna @fauxpark