Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ajp10304 userspace and ortho_4x12 layout. #9304

Merged
merged 17 commits into from
Jul 9, 2020
Merged

Create ajp10304 userspace and ortho_4x12 layout. #9304

merged 17 commits into from
Jul 9, 2020

Conversation

ajp10304
Copy link
Contributor

@ajp10304 ajp10304 commented Jun 4, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ajp10304 ajp10304 force-pushed the feature/ajp10304_userspace branch from c110bea to 2cb48bd Compare June 5, 2020 12:33
@ajp10304 ajp10304 requested a review from drashna June 7, 2020 20:55
@ajp10304
Copy link
Contributor Author

ajp10304 commented Jun 7, 2020

@drashna Sorry, clicked "Request re-review" by accident. Sorry!

drashna
drashna approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries.

@drashna drashna requested a review from a team June 8, 2020 06:28
@drashna drashna added the keymap label Jun 8, 2020
fauxpark
fauxpark requested changes Jul 1, 2020
View reviewed changes
keyboards/handwired/atreus50/keymaps/ajp10304/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/atreus50/keymaps/ajp10304/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/atreus50/keymaps/ajp10304/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/atreus50/keymaps/ajp10304/rules.mk Outdated Show resolved Hide resolved
keyboards/jj40/keymaps/ajp10304/readme.md Outdated Show resolved Hide resolved
keyboards/acheron/shark/keymaps/ajp10304/readme.md Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/readme.md Outdated Show resolved Hide resolved
users/ajp10304/rules.mk Outdated Show resolved Hide resolved
@Erovia Erovia requested review from fauxpark and noroadsleft July 1, 2020 20:25
fauxpark
fauxpark requested changes Jul 2, 2020
View reviewed changes
keyboards/acheron/shark/keymaps/ajp10304/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/atreus50/keymaps/ajp10304/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/atreus50/keymaps/ajp10304/rules.mk Outdated Show resolved Hide resolved
keyboards/jj40/keymaps/ajp10304/readme.md Outdated Show resolved Hide resolved
layouts/community/ortho_4x12/ajp10304/readme.md Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jul 2, 2020
View reviewed changes
users/ajp10304/ajp10304.h Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.h Outdated Show resolved Hide resolved
drashna
drashna requested changes Jul 5, 2020
View reviewed changes
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jul 6, 2020
View reviewed changes
users/ajp10304/ajp10304.h Outdated Show resolved Hide resolved
layouts/community/ortho_4x12/ajp10304/keymap.c Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
users/ajp10304/ajp10304.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 8, 2020 13:11
@Erovia Erovia merged commit c5e255a into qmk:master Jul 9, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@ajp10304
Create ajp10304 userspace and ortho_4x12 layout. (qmk#9304)
1d64d37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajp10304 @drashna @Erovia @fauxpark @noroadsleft