Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/feature_layers.md #9252

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented May 31, 2020

Description

Add a Japanese translation of docs/feature_layers.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented May 31, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
@mtei
Copy link
Contributor

mtei commented Jun 13, 2020

レビューを、やりかけたのですが、どうも読んで添削した覚えのある文章です。
ちょっと原文の履歴をあたってみたところ、今年の3月22日に、#8371 で、
以下が変更され、

  • docs/_summary.md (訳出済み、feature_layers.mdは含まれているので、修正不要)
  • docs/feature_advanced_keycodes.md (5d5ff80 3月20日版を訳出済み、要修正)
  • docs/feature_leader_key.md (0.8.134 4月27日版を訳出済み)
  • docs/keycodes.md (未訳)

以下が新規追加になっているので

  • docs/feature_layers.md

文章の移動があったのですね。

このPRで、上記の feature_advanced_keycodes.md も一緒に 0.9.0 ベースで、更新をした方がよさそうですが、いかがでしょうか?

docs/ja/feature_layers.md Outdated Show resolved Hide resolved
@umi-umi
Copy link
Contributor Author

umi-umi commented Jun 19, 2020

ドキュメントの移動状況まで確認していただきありがとうございます。
・feature_advanced_keycodes.md
・feature_layers.md
を tag 0.9.0 ベースで更新しました。
よろしくお願いいたします。

docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
docs/ja/feature_layers.md Outdated Show resolved Hide resolved
@mtei mtei requested review from noroadsleft and a team June 22, 2020 15:42
Copy link
Contributor

@shelaf shelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

関連PRとして #9492 を投げています。近いうちにマージされると思いますが、このマージを待って内容を取り込むかどうかはお任せします

@mtei
Copy link
Contributor

mtei commented Jun 23, 2020

関連PRとして #9492 を投げています。近いうちにマージされると思いますが、このマージを待って内容を取り込むかどうかはお任せします

9492 をマージしました。ただ取り込むのは TAG が振られてからの方が良いので、この PR は一旦完成としたいと思います。

@mtei mtei merged commit b3b6176 into qmk:master Jun 23, 2020
@mtei
Copy link
Contributor

mtei commented Jun 23, 2020

Thanks !

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara
umi-umi さん、レビュアーの皆さん、お疲れ様です。数えてみたら翻訳済みのファイルは、半分を超えていました。素晴らしい!!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* add feature_layers.md translation

* update based on comment

* update based on comment

* update based on comment
@umi-umi umi-umi deleted the feature_layers.md-japanese-translation branch July 10, 2020 16:42
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* add feature_layers.md translation

* update based on comment

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants