Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility #9207

Merged
merged 11 commits into from
Jun 11, 2020
Merged

Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility #9207

merged 11 commits into from
Jun 11, 2020

Conversation

catrielmuller
Copy link
Contributor

@catrielmuller catrielmuller commented May 26, 2020 •
edited
Loading

Description

I needed create a keyboard for a person that can only use one finger at the time. So I changed the all mod keys to the One Keypress variation, so all key bindings can be done with one finger.

The console = no it's to reduce the size of the binary to support Unicode

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes May 27, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the kbd67/rev2:cami keymap to kbd67/rev2:catrielmuller so that it matches your existing dztech/dz65rgb:catrielmuller keymap.

@zvecr zvecr added the keymap label May 27, 2020
@catrielmuller
Copy link
Contributor Author

Can we rename the kbd67/rev2:cami keymap to kbd67/rev2:catrielmuller so that it matches your existing dztech/dz65rgb:catrielmuller keymap.

I changed on the last commit to catrielmuller_camilad because that keyboard was a gift to a person that have some motor problems in the hands, so this keymap it's for she can use the all keyboard with a single finger.
I will check on the weekend if i can implement on the makefile the possibility to handle subfolders for the keymaps like catrielmuller/camilad.
I don't wanna use only my username because i have other kbd67, so probably i will create another keymap for the other board

@zvecr
Copy link
Member

zvecr commented May 28, 2020

Ah thats a valid use case, in which case i think would accept either what you had or what is there now. I had assumed that it was a personal keymap... you know what they say about assumptions.

As for nested keymap folders, I don't think that's something we would want to support right now.

@catrielmuller
Copy link
Contributor Author

Ah thats a valid use case, in which case i think would accept either what you had or what is there now. I had assumed that it was a personal keymap... you know what they say about assumptions.

As for nested keymap folders, I don't think that's something we would want to support right now.

Ok, so i think with a lodash it's a good way to differentiate that.
Lmk if you have another comment of this PR. Thanks for your time.

@zvecr zvecr requested a review from a team June 10, 2020 22:44
@catrielmuller
Copy link
Contributor Author

Thanks @fauxpark

@zvecr zvecr requested a review from fauxpark June 11, 2020 12:16
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit ccb4b81 into qmk:master Jun 11, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
Merge remote-tracking branch 'upstream/master'
2ecd1de 
* upstream/master: (82 commits)
  Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility (qmk#9207)
  Murcielago: improve default keymap (qmk#9363)
  Really fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9370)
  Fix Configurator layout data for clueboard/2x1800/2019 (qmk#9373)
  Fixing Iron165 VIA Keymap (qmk#9298)
  Fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9307)
  Add documentation for selecting an Arm MCU (qmk#9046)
  [Docs] Fixed the hyperlink to `/users/_example/`. (qmk#9326)
  [keyboard] Project Keyboard Signature 87 (qmk#9062)
  Include `pointing_device_send` in docs (qmk#9185)
  Fix one shot swaphands compiler error when NO_ACTION_ONESHOT is defined (qmk#9296)
  [Keymap] WPM-responsive OLED animation in personal keymap (qmk#9264)
  Add bat43 rev2 (qmk#9319)
  [Keymap] Add dual layer keymap for xd002 macropad (qmk#9222)
  [Keyboard] Wazowski 23-19 PCB Support (qmk#9198)
  adds support for the atmega328 (qmk#9043)
  fix rgb mode selection and lighting increments for the 1894 (qmk#9336)
  Add Sinc keyboard (qmk#8986)
  Add new iris keymap 'fluffactually' (qmk#9325)
  kbdfans/kbd67/rev2: Fix ISO layout macro (qmk#9329)
  ...
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jun 12, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
35ed72f 
* 'master' of https://github.com/qmk/qmk_firmware: (461 commits)
  Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility (qmk#9207)
  Murcielago: improve default keymap (qmk#9363)
  Really fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9370)
  Fix Configurator layout data for clueboard/2x1800/2019 (qmk#9373)
  Fixing Iron165 VIA Keymap (qmk#9298)
  Fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9307)
  Add documentation for selecting an Arm MCU (qmk#9046)
  [Docs] Fixed the hyperlink to `/users/_example/`. (qmk#9326)
  [keyboard] Project Keyboard Signature 87 (qmk#9062)
  Include `pointing_device_send` in docs (qmk#9185)
  Fix one shot swaphands compiler error when NO_ACTION_ONESHOT is defined (qmk#9296)
  [Keymap] WPM-responsive OLED animation in personal keymap (qmk#9264)
  Add bat43 rev2 (qmk#9319)
  [Keymap] Add dual layer keymap for xd002 macropad (qmk#9222)
  [Keyboard] Wazowski 23-19 PCB Support (qmk#9198)
  adds support for the atmega328 (qmk#9043)
  fix rgb mode selection and lighting increments for the 1894 (qmk#9336)
  Add Sinc keyboard (qmk#8986)
  Add new iris keymap 'fluffactually' (qmk#9325)
  kbdfans/kbd67/rev2: Fix ISO layout macro (qmk#9329)
  ...
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@catrielmuller @fauxpark @turky
Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with i…
ec3ad0d 
…mprovements on Accessibility (qmk#9207)

Co-authored-by: Ryan <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@catrielmuller @fauxpark @jakobaa
Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with i…
d40844b 
…mprovements on Accessibility (qmk#9207)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catrielmuller @zvecr @fauxpark