Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid 'Entering|Leaving directory' messages #9061

Merged
merged 1 commit into from
May 14, 2020
Merged

Avoid 'Entering|Leaving directory' messages #9061

merged 1 commit into from
May 14, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 10, 2020 •
edited
Loading

Description

Recent arch install produces:

$ make handwired/onekey:all LTO_ENABLE=yes
QMK Firmware 0.8.144
Making handwired/onekey/promicro with keymap adc                                                       [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap backlight                                                 [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap default                                                   [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap i2c_scanner                                               [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap reset                                                     [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap rgb                                                       [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'
Making handwired/onekey/promicro with keymap test                                                      [WARNINGS]
make[1]: Entering directory '/home/zvecr/qmk_firmware'
make[1]: Leaving directory '/home/zvecr/qmk_firmware'

Without something like make -s or the change in this PR, the above "Entering|Leaving directory" logic triggers erroneous build warnings.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team May 10, 2020 01:08
fauxpark
fauxpark approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seeing this on MSYS.

tzarc
tzarc approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything on Ubuntu 20.04 or macOS Catalina. Seems fair enough.

@zvecr zvecr merged commit 2dd47a3 into qmk:master May 14, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@zvecr @lorenzoernesto
avoid 'Entering|Leaving directory' messages (qmk#9061)
f7535ff
@zvecr zvecr deleted the featureavoid_directory_messages branch May 21, 2020 20:19
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@zvecr @drashna
avoid 'Entering|Leaving directory' messages (qmk#9061)
0d9318f
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@zvecr @sowbug
avoid 'Entering|Leaving directory' messages (qmk#9061)
a9bb653
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@zvecr @fdidron
avoid 'Entering|Leaving directory' messages (qmk#9061)
375e2d7
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@zvecr @turky
avoid 'Entering|Leaving directory' messages (qmk#9061)
5671fc2
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@zvecr @jakobaa
avoid 'Entering|Leaving directory' messages (qmk#9061)
769911d
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@zvecr @sjmacneil
avoid 'Entering|Leaving directory' messages (qmk#9061)
6043ed6
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
avoid 'Entering|Leaving directory' messages (qmk#9061)
9277b8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @fauxpark