Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix links in feature_hd44780.md #9053

Merged
merged 1 commit into from
May 9, 2020
Merged

Conversation

noroadsleft
Copy link
Member

The referenced site was moved.

Types of Changes

  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires is a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The referenced site was moved.
@noroadsleft noroadsleft requested a review from a team May 9, 2020 02:48
@noroadsleft
Copy link
Member Author

@mtei Seems the site move was already discovered and noted in the Japanese documentation. Feel free to update or have your team update the Japanese version whenever is convenient.

Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks. Good To Me.

@mtei
Copy link
Contributor

mtei commented May 9, 2020

@mtei Seems the site move was already discovered and noted in the Japanese documentation. Feel free to update or have your team update the Japanese version whenever is convenient.

Thanks for letting me know.

The following blocks have been added to the all Japanese translations.

<!---
  original document: 0.8.123:docs/feature_hd44780.md
  git diff 0.8.123 HEAD -- docs/feature_hd44780.md | cat
-->

Once this PR is merged, we as Japanese translators can easily follow the changes.

@zvecr zvecr merged commit 7b11dcc into qmk:master May 9, 2020
@noroadsleft noroadsleft deleted the docs/hd44780 branch May 10, 2020 02:00
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants