Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Switch to nano specs on ChibiOS builds" #9044

Merged
merged 1 commit into from
May 8, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 8, 2020

Reverts #8270

Fixes #8809

syscalls_cpp.cpp contains some of the required stub functions, however on this arch environment it produces:

  • multiple definition of `__dso_handle'
  • +2k firmware size over nosys

For the most part, ARM users are not strapped for space. So I put the case that it is better to have working builds across the board in the short term, while a potential longer term solution is worked on.

@zvecr zvecr requested review from tzarc and a team May 8, 2020 00:28
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be working fine on the couple of boards I tested with.

@tzarc tzarc requested a review from a team May 8, 2020 07:32
@tzarc
Copy link
Member

tzarc commented May 8, 2020

Also confirmed that this fixes builds on Ubuntu 20.04.

@zvecr zvecr merged commit adda5d7 into master May 8, 2020
@drashna drashna deleted the revert-8270-feature/nanospecs branch May 9, 2020 08:30
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] arm-none-eabi-gcc error on Arch Linux
2 participants