Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a-ball handwired trackball based on ADSN9800 #9015

Merged
merged 28 commits into from
Jan 8, 2022
Merged

Add a-ball handwired trackball based on ADSN9800 #9015

merged 28 commits into from
Jan 8, 2022

Conversation

brickbots
Copy link
Contributor

It's a trackball running QMK, with no buttons at all! Designed to be used as an adjunct to another keyboard to provide pointing capabilities, while the keyboard itself provides mouse button functionality.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes May 4, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be refactored to use https://docs.qmk.fm/#/spi_driver

@zvecr zvecr added the keyboard label May 4, 2020
@brickbots
Copy link
Contributor Author

This should be refactored to use https://docs.qmk.fm/#/spi_driver

Thank you @zvecr for pointing out the QMK driver here. I've refactored the code to use it 👍

@brickbots brickbots requested a review from zvecr May 26, 2020 02:45
zvecr
zvecr requested changes May 27, 2020
View reviewed changes
keyboards/handwired/aball/adns.h Outdated Show resolved Hide resolved
keyboards/handwired/aball/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/adns.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/rules.mk Outdated Show resolved Hide resolved
@brickbots
Copy link
Contributor Author

Thank you @zvecr for your patient guidance and suggestions! I've actioned all of your suggestions and pushed this branch again. Cheers!

@drashna drashna requested a review from a team June 3, 2020 05:30
fauxpark
fauxpark requested changes Jun 3, 2020
View reviewed changes
keyboards/handwired/aball/adns9800_srom_A6.h Outdated Show resolved Hide resolved
keyboards/handwired/aball/adns.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/adns.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/adns.c Outdated Show resolved Hide resolved
@brickbots
Copy link
Contributor Author

Hi @fauxpark . Thank you for your suggestions to use the newer debug features rather than print. Much appreciated! 👍

@drashna drashna requested a review from a team June 18, 2020 02:32
@brickbots brickbots requested review from fauxpark and zvecr and removed request for a team July 4, 2020 01:31
@tzarc
Copy link
Member

tzarc commented Jul 22, 2020

My only reservation with merging this is the firmware -- there's no license or comments as to where it came from.

@brickbots
Copy link
Contributor Author

Hi @fauxpark and @zvecr !

I appreciate both of your time and help so far. If I have missed a comment or change request somewhere along the line I apologize, but I'm not sure what needs to be done to get this PR merged. Would it be please be possible to get more notes, or an approval, on this pull request?

Thanks!

@stale
Copy link

stale bot commented Mar 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Mar 17, 2021
@drashna drashna requested a review from a team March 17, 2021 06:58
drashna
drashna requested changes Dec 7, 2021
View reviewed changes
keyboards/handwired/aball/adns.c Outdated Show resolved Hide resolved
keyboards/handwired/aball/adns.h Outdated Show resolved Hide resolved
keyboards/handwired/aball/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/aball/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/aball/rules.mk Outdated Show resolved Hide resolved
@brickbots
Copy link
Contributor Author

Thanks @drashna for the suggestions to bring this PR up to snuff with the recent develop branch changes. It's exciting to see first class support for the ADNS9800 sensor!

@drashna
Copy link
Member

drashna commented Dec 7, 2021

Thanks @drashna for the suggestions to bring this PR up to snuff with the recent develop branch changes. It's exciting to see first class support for the ADNS9800 sensor!

Welcome! And honestly, I'm happy to add first class support for as many sensors as I can.

Also, it may be worth adding some of the defines from:
#15304

I've been using those code changes, and they're fantastic.

fauxpark
fauxpark requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing info.json.

keyboards/handwired/aball/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/aball/config.h Outdated Show resolved Hide resolved
@brickbots
Copy link
Contributor Author

Thanks @fauxpark for the feedback on the feature description changes and the reminder about info.json! I appreciate it 👍

noroadsleft
noroadsleft approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit a2ed670 into qmk:master Jan 8, 2022
@noroadsleft
Copy link
Member

Thanks!

ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@brickbots @ryphon
Add a-ball handwired trackball based on ADSN9800 (qmk#9015)
53474f3 
* Initial commit of kball

* Pretty much working

* Rename to aball

* Cleanup

* Fix typo and make instructions

* Refactor to use qmk spi

* Suggestions from ZVECR

* Update keyboards/handwired/aball/adns9800_srom_A6.h

* Update keyboards/handwired/aball/adns.c

* Update keyboards/handwired/aball/adns.c

* Update keyboards/handwired/aball/adns.c

* Added copyright and source attribution

* Update keyboards/handwired/aball/rules.mk

Include as quantum lib to help avoid timing issues with LTO

* Only send report on change, adj sensitivity, fix src include

* Fix issue causing constant reports and bad clamping

* Streamline conversion to int, add required wait before burst read

* Changes to track develop

* Update rules with new feature descriptors, add info.json

* Add stub layout

* Rework / cleanup key matrix.  Add missing CS pin define for new ADNS driver

* Add stub keymap to enable compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
awaiting review keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brickbots @tzarc @drashna @noroadsleft @fauxpark @zvecr