Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Le Chiffre keyboard #8995

Merged
merged 10 commits into from
May 8, 2020
Merged

Add Le Chiffre keyboard #8995

merged 10 commits into from
May 8, 2020

Conversation

tominabox1
Copy link
Contributor

@tominabox1 tominabox1 commented May 2, 2020 •
edited by zvecr
Loading

Description

Add new keyboard Le Chiffre to master branch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label May 2, 2020
zvecr
zvecr requested changes May 2, 2020
View reviewed changes
keyboards/le_chiffre/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/le_chiffre/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/le_chiffre/keymaps/default/keymap.c Outdated

switch (get_highest_layer(layer_state)) {
case _BASE:
if (Caps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Caps) {
if (host_keyboard_led_state().caps_lock) {

keyboards/le_chiffre/le_chiffre.h Outdated Show resolved Hide resolved
keyboards/le_chiffre/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/le_chiffre/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team May 2, 2020 16:17
noroadsleft
noroadsleft requested changes May 7, 2020
View reviewed changes
keyboards/le_chiffre/info.json Outdated Show resolved Hide resolved
keyboards/le_chiffre/readme.md Outdated Show resolved Hide resolved
keyboards/le_chiffre/rules.mk Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from zvecr May 8, 2020 18:31
@zvecr zvecr merged commit fedd8e8 into qmk:master May 8, 2020
@zvecr
Copy link
Member

zvecr commented May 8, 2020

Thanks!

@tominabox1 tominabox1 deleted the Le-Chiffre-Keyboard branch May 9, 2020 00:19
@tominabox1
Copy link
Contributor Author

Thanks Team!

bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@tominabox1 @noroadsleft @lorenzoernesto
Add Le Chiffre keyboard (qmk#8995)
4d8ac51 
* Initial

* update json, added basic oled config, updated matrix to correct rotary location

* disable oled by default

* Tuned oled for release

* Completed OLED function implementation
Correct spelling error in readme

* Fixed image in readme

* Should not be in this branch

* Incorporating recommended changes by zvecr

* Update keyboards/le_chiffre/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/le_chiffre/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@tominabox1 @noroadsleft @sowbug
Add Le Chiffre keyboard (qmk#8995)
6afba3c 
* Initial

* update json, added basic oled config, updated matrix to correct rotary location

* disable oled by default

* Tuned oled for release

* Completed OLED function implementation
Correct spelling error in readme

* Fixed image in readme

* Should not be in this branch

* Incorporating recommended changes by zvecr

* Update keyboards/le_chiffre/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/le_chiffre/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@tominabox1 @noroadsleft @turky
Add Le Chiffre keyboard (qmk#8995)
1ba2350 
* Initial

* update json, added basic oled config, updated matrix to correct rotary location

* disable oled by default

* Tuned oled for release

* Completed OLED function implementation
Correct spelling error in readme

* Fixed image in readme

* Should not be in this branch

* Incorporating recommended changes by zvecr

* Update keyboards/le_chiffre/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/le_chiffre/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@tominabox1 @noroadsleft @jakobaa
Add Le Chiffre keyboard (qmk#8995)
fd2396e 
* Initial

* update json, added basic oled config, updated matrix to correct rotary location

* disable oled by default

* Tuned oled for release

* Completed OLED function implementation
Correct spelling error in readme

* Fixed image in readme

* Should not be in this branch

* Incorporating recommended changes by zvecr

* Update keyboards/le_chiffre/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/le_chiffre/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@tominabox1 @noroadsleft @sjmacneil
Add Le Chiffre keyboard (qmk#8995)
0d0f2d2 
* Initial

* update json, added basic oled config, updated matrix to correct rotary location

* disable oled by default

* Tuned oled for release

* Completed OLED function implementation
Correct spelling error in readme

* Fixed image in readme

* Should not be in this branch

* Incorporating recommended changes by zvecr

* Update keyboards/le_chiffre/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/le_chiffre/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tominabox1 @zvecr @noroadsleft