Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the VID/PID for Helix keyboards #8989

Merged
merged 1 commit into from
May 7, 2020
Merged

Changed the VID/PID for Helix keyboards #8989

merged 1 commit into from
May 7, 2020

Conversation

MakotoKurauchi
Copy link
Contributor

Description

Change the vendor ID and product ID.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label May 2, 2020
@zvecr zvecr requested a review from a team May 2, 2020 14:07
mtei
mtei approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me.

"#define MANUFACTURER Yushakobo" --> https://www.the-sz.com/products/usbid/index.php?n=Yushakobo

@mtei mtei requested a review from a team May 2, 2020 15:02
@noroadsleft noroadsleft changed the title Changed the VID/PID Changed the VID/PID for Helix keyboards May 7, 2020
@noroadsleft noroadsleft merged commit 5d29a13 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@MakotoKurauchi @brandonschlack
Changed the VID/PID for Helix keyboards (qmk#8989)
cd40527
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@MakotoKurauchi @lorenzoernesto
Changed the VID/PID for Helix keyboards (qmk#8989)
783b117
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@MakotoKurauchi @sowbug
Changed the VID/PID for Helix keyboards (qmk#8989)
c6b40c8
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@MakotoKurauchi @turky
Changed the VID/PID for Helix keyboards (qmk#8989)
14fe4d2
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@MakotoKurauchi @jakobaa
Changed the VID/PID for Helix keyboards (qmk#8989)
2a5cf05
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@MakotoKurauchi @sjmacneil
Changed the VID/PID for Helix keyboards (qmk#8989)
9eded72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MakotoKurauchi @noroadsleft @mtei @zvecr