add adelais en ciel #8944
Closed
add adelais en ciel #8944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alice compatible RGB PCB
drashna
approved these changes
Apr 29, 2020
fauxpark
requested changes
Apr 29, 2020
drashna
requested changes
Apr 29, 2020
| */ | ||
|
|
||
| #include "adelais_en_ciel.h" | ||
| led_config_t g_led_config = { { |
There was a problem hiding this comment.
Suggested change
| led_config_t g_led_config = { { | |
| #ifdef RGB_MATRIX_ENABLE | |
| led_config_t g_led_config = { { |
There was a problem hiding this comment.
this pcb is rgb pcb, so i think we don't need to define RGB_MATRIX_ENABLE
There was a problem hiding this comment.
It is, but somebody may want to ... shudders disable the RGB matrix on the board.
And if they do, the compile will fail if this isn't behind a preprocessor ifdef.
| 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, | ||
| 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, | ||
| 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, | ||
| } }; |
There was a problem hiding this comment.
Suggested change
| } }; | |
| } }; | |
| #endif |
|
Thank you! Have to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Adelais en ciel - compatible with TGR Alice and all clone variants
Types of Changes
Issues Fixed or Closed by This PR
Checklist