Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new keyboard pisces #8943

Merged
merged 5 commits into from
May 7, 2020
Merged

Conversation

mechlovin
Copy link
Contributor

Description

Add pisces PCB (private GB) with VIA keymap added in.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna requested a review from a team April 29, 2020 09:00
keyboards/mechlovin/pisces/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 29, 2020 16:46
@zvecr zvecr requested a review from fauxpark May 1, 2020 19:49
keyboards/mechlovin/pisces/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/pisces/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/pisces/rules.mk Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 43868a5 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
@mechlovin mechlovin deleted the dev_mechlovin-pisces branch May 8, 2020 07:30
myuhe pushed a commit to myuhe/qmk_firmware that referenced this pull request May 8, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* add new keyboard

* clean up

* Update rules.mk

* Update rules.mk

* update

Co-authored-by: vuhopkep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants