Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: TGR 910 CE #8940

Merged
merged 12 commits into from
Apr 28, 2020
Merged

New Keyboard: TGR 910 CE #8940

merged 12 commits into from
Apr 28, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 27, 2020 •
edited
Loading

Description

New Keyboard TGR 910 CE (Note this is different than the 910) with VIA keymap added in.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 27, 2020 04:41
noroadsleft
noroadsleft requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good to me.

keyboards/tgr/910ce/info.json Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit d322ec5 into qmk:master Apr 28, 2020
@noroadsleft
Copy link
Member

Thanks!

@mechmerlin mechmerlin mentioned this pull request Apr 28, 2020
Merged
6 tasks
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@mechmerlin @violet-fish
[Keyboard] TGR 910 CE (qmk#8940)
0fe22c1 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@mechmerlin @lorenzoernesto
[Keyboard] TGR 910 CE (qmk#8940)
6d5103d 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@mechmerlin @sowbug
[Keyboard] TGR 910 CE (qmk#8940)
3229280 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@mechmerlin @turky
[Keyboard] TGR 910 CE (qmk#8940)
ac3d80a 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@mechmerlin @jakobaa
[Keyboard] TGR 910 CE (qmk#8940)
4501f3d 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
@mechmerlin mechmerlin deleted the feature/tgr910ce branch January 26, 2021 14:59
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@mechmerlin @sjmacneil
[Keyboard] TGR 910 CE (qmk#8940)
ca38ee2 
* initial commit for TGR 910 CE

* got firmware working on the 910 CE

* add VIA support

* add iso and all layouts

* update information about resetting the board

* fixup default keymap to have a second layer

* fixup default keymap

* add VIA enabled keymap

* cleanups and adding community layout support

* add caps lock led support and backlight

* add qmk configurator support

* Update keyboards/tgr/910ce/info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mechmerlin @noroadsleft @fauxpark