Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ek87 PCB support #8937

Merged
merged 31 commits into from
May 7, 2020
Merged

Added ek87 PCB support #8937

merged 31 commits into from
May 7, 2020

Conversation

eniigmakeyboards
Copy link
Contributor

Description

Added support for the ek87 PCB, designed for Eniigma Keyboards TKL products.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@eniigmakeyboards eniigmakeyboards mentioned this pull request Apr 26, 2020
Merged
6 tasks
zvecr
zvecr requested changes Apr 26, 2020
View reviewed changes
keyboards/eniigmakeyboards/ek87/config.h Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/ek87.c Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/keymaps/default_ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/rules.mk Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Apr 26, 2020
@zvecr zvecr requested a review from a team April 26, 2020 21:40
zvecr
zvecr requested changes Apr 26, 2020
View reviewed changes
keyboards/eniigmakeyboards/ek87/rules.mk Outdated Show resolved Hide resolved
eniigmakeyboards
eniigmakeyboards commented Apr 26, 2020
View reviewed changes
Copy link
Contributor Author

@eniigmakeyboards eniigmakeyboards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should be fixed

keyboards/eniigmakeyboards/ek87/rules.mk Outdated Show resolved Hide resolved
eniigmakeyboards
eniigmakeyboards commented Apr 27, 2020
View reviewed changes
Copy link
Contributor Author

@eniigmakeyboards eniigmakeyboards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all changes

noroadsleft
noroadsleft requested changes Apr 27, 2020
View reviewed changes
keyboards/eniigmakeyboards/ek87/ek87.h Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/ek87.h Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/ek87.h Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/readme.md Outdated Show resolved Hide resolved
@eniigmakeyboards eniigmakeyboards requested a review from fauxpark May 2, 2020 19:21
noroadsleft
noroadsleft requested changes May 7, 2020
View reviewed changes
keyboards/eniigmakeyboards/ek87/ek87.h Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/ek87.h Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
keyboards/eniigmakeyboards/ek87/info.json Outdated Show resolved Hide resolved
eniigmakeyboards and others added 9 commits May 7, 2020 08:09
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/ek87.h
c8782a3 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/ek87.h
55fe0b1 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
fd77fd3 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
06a2050 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
ee97d60 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
4708b9c 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
5dedf8a 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
fa590c4 
Co-authored-by: James Young <[email protected]>
@eniigmakeyboards @noroadsleft
Update keyboards/eniigmakeyboards/ek87/info.json
11e97ae 
Co-authored-by: James Young <[email protected]>
@noroadsleft noroadsleft merged commit d258188 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

@eniigmakeyboards
Copy link
Contributor Author

Thank you very much!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@eniigmakeyboards @brandonschlack
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
89233b8 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
myuhe pushed a commit to myuhe/qmk_firmware that referenced this pull request May 8, 2020
@eniigmakeyboards @myuhe
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
9d50b33 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@eniigmakeyboards @lorenzoernesto
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
80e94ee 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@eniigmakeyboards @sowbug
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
addf819 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@eniigmakeyboards @turky
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
c67128e 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@eniigmakeyboards @jakobaa
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
6b91103 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@eniigmakeyboards @sjmacneil
[Keyboard] Eniigma Keyboards ek87 (qmk#8937)
b14f936 
* Added ek87 support

* Fixed readme

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/config.h

* Update keyboards/eniigmakeyboards/ek87/ek87.c

* fixed title

* Deleted old files

* Added rules.mk file to VIA keymap folder

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Deleted requested file

* Removed VIA line from rules

* Update keyboards/eniigmakeyboards/ek87/readme.md

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/keymaps/default/keymap.c

* Update keyboards/eniigmakeyboards/ek87/keymaps/via/keymap.c

* Renamed layouts and removed obsolete ones

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/rules.mk

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/ek87.h

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json

* Update keyboards/eniigmakeyboards/ek87/info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eniigmakeyboards @noroadsleft @fauxpark @zvecr