[kle2json] fix rounding in output #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skullydazed
reviewed
Apr 26, 2020
resolves an issue while finding the file path TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'
fixes quirks with float implementation.
before:
{"label":"Esc", "x":0.66, "y":1.45}, {"label":"!", "x":1.6600000000000001, "y":1.45}
after:
{"label":"Esc", "x":0.66, "y":1.45}, {"label":"!", "x":1.66, "y":1.45}
|
thanks @skullydazed - fixed |
skullydazed
approved these changes
Apr 26, 2020
zvecr
approved these changes
Apr 26, 2020
|
Thanks! |
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
[kle2json] fix rounding in output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two tweaks to the code that converts from keyboard layout editor json to qmk info json files:
Remove error on command line execution
Remove an error thrown in python 3.7.7 (more recent than the targeted 3.6):
Round x and y output
[...] "layouts": { "LAYOUT": { - "layout": [{"label":"Esc", "x":0.66, "y":1.45}, {"label":"!", "x":1.6600000000000001, "y":1.45}, + "layout": [{"label":"Esc", "x":0.66, "y":1.45}, {"label":"!", "x":1.66, "y":1.45},Types of Changes
Checklist
PS
Starting small as I'm starting to understand python and qmk in general.