Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make personal keymaps a bit more consistent #8915

Merged
merged 6 commits into from
Apr 26, 2020
Merged

Make personal keymaps a bit more consistent #8915

merged 6 commits into from
Apr 26, 2020

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Apr 25, 2020

Description

Just tidying up some inconsistencies across my less-frequently-used keyboard layouts after #8836 and #8857 reworked my preferred (Crkbd, Tsangan) layouts to reflect current preferences.

  • Put Menu key binding in a uniform location across keyboards.
  • Move backlight controls to a conflict-free location across keyboards.
  • Standardize labeling of layers on row-staggered keyboards.
  • Tweak non-Tsangan bottom rows so they make a little more sense to me.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keymap label Apr 25, 2020
@zvecr zvecr requested a review from a team April 25, 2020 21:59
@noroadsleft noroadsleft merged commit 4597f2b into qmk:master Apr 26, 2020
@noroadsleft
Copy link
Member

Thanks!

@bcat bcat deleted the bcat_keebs branch April 26, 2020 17:46
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@bcat @violet-fish
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
723d40a 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@bcat @lorenzoernesto
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
bba9f6e 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@bcat @sowbug
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
099a7c2 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@bcat @turky
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
eccc098 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@bcat @jakobaa
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
1f3a9db 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@bcat @sjmacneil
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
a28d816 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@bcat
[Keymap] Make personal keymaps a bit more consistent (qmk#8915)
cdb4411 
* Move menu key on ergo boards to match staggered

* Unify 60_tsangan_hhkb and 60_ansi_split_bs_rshift

* Sync KBD67, Quefrency with community layouts

* Update ergo KLE images

* Update community layout KLE images

* Update KLE images/descriptions for remaining keebs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcat @noroadsleft @zvecr