Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update shell.nix #8910

Merged
merged 1 commit into from
Jun 20, 2020
Merged

update shell.nix #8910

merged 1 commit into from
Jun 20, 2020

Conversation

thorstenweber83
Copy link
Contributor

Description

update shell.nix to use up to date nixpkgs

  • now uses gcc 8.4
  • fixes building boards with adafruit feather (in my case the pancake)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • building for adafruit feather

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@thorstenweber83
shell.nix: update nixpkgs to #903266491b7b9b0379e88709feca0af900def0d9
eeae3a0 
* now uses gcc 8.4
* fixes building boards with adafruit feather (in my case pancake)
@zvecr zvecr added the core label Apr 25, 2020
@zvecr zvecr requested review from a team and tzarc April 25, 2020 21:57
@drashna drashna requested a review from a team April 29, 2020 05:57
@stale
Copy link

stale bot commented Jun 13, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@emptyflask
Copy link
Contributor

Works for me. I used this to build and flash my Preonic firmware on NixOS.

@stale stale bot removed the awaiting changes label Jun 20, 2020
@Erovia Erovia merged commit e58ab6d into qmk:master Jun 20, 2020
@thorstenweber83 thorstenweber83 deleted the tw/update-shell.nix branch June 21, 2020 09:55
@purcell purcell mentioned this pull request Jun 26, 2020
Merged
13 tasks
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@thorstenweber83 @jakobaa
update shell.nix (qmk#8910)
207a24d 
* now uses gcc 8.4
* fixes building boards with adafruit feather (in my case pancake)
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 9, 2020
@thorstenweber83 @drashna
update shell.nix (qmk#8910)
957111d 
* now uses gcc 8.4
* fixes building boards with adafruit feather (in my case pancake)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@thorstenweber83
update shell.nix (qmk#8910)
0642787 
* now uses gcc 8.4
* fixes building boards with adafruit feather (in my case pancake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@Erovia Erovia Erovia approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thorstenweber83 @emptyflask @drashna @Erovia @zvecr