Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keebio lighting defaults #8884

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Add Keebio lighting defaults #8884

merged 2 commits into from
Apr 25, 2020

Conversation

nooges
Copy link
Member

@nooges nooges commented Apr 22, 2020

Description

Adds lighting defaults for Keebio boards, so users aren't confused that their lighting isn't working.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@drashna drashna requested a review from a team April 23, 2020 20:23
@noroadsleft noroadsleft merged commit 32bab55 into qmk:master Apr 25, 2020
@noroadsleft
Copy link
Member

Thanks!

@nooges nooges deleted the keebio-eeprom-default branch April 26, 2020 03:11
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@nooges @violet-fish
Add Keebio lighting defaults (qmk#8884)
8f725b9 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@nooges @lorenzoernesto
Add Keebio lighting defaults (qmk#8884)
7261a88 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@nooges @sowbug
Add Keebio lighting defaults (qmk#8884)
2d8b2e8 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@nooges @turky
Add Keebio lighting defaults (qmk#8884)
145113c 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@nooges @jakobaa
Add Keebio lighting defaults (qmk#8884)
50a20b0 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@nooges @sjmacneil
Add Keebio lighting defaults (qmk#8884)
8b966eb 
* Set Iris LED/RGB defaults

* Add lighting defaults for more boards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nooges @noroadsleft @drashna