Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for Minivan #8849

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Add VIA support for Minivan #8849

merged 2 commits into from
Apr 19, 2020

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Apr 19, 2020

Description

This is the 4th json keymap in the repo and the first one with VIA support. 😎

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia added the keymap label Apr 19, 2020
@Erovia Erovia requested a review from a team April 19, 2020 08:22
@zvecr zvecr added the keyboard label Apr 19, 2020
@zvecr zvecr requested a review from a team April 19, 2020 13:28
@Erovia Erovia merged commit 51ecd37 into qmk:master Apr 19, 2020
@Erovia Erovia deleted the via/minivan branch April 19, 2020 16:44
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants