Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for overriding RAW endpoint usage page and ID. #8834

Merged
merged 3 commits into from
May 21, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 18, 2020

Description

Adds support for overriding the RAW endpoint's usage page and ID.
Sanity checked by compiling make all:via -- no errors.
We have #7640 in the pipeline for documenting the RAW endpoint, will wait for that to merge before suggesting appropriate changes to the documentation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 18, 2020 00:38
@tzarc tzarc self-assigned this Apr 18, 2020
@fauxpark
Copy link
Member

What's the use case for this?

quantum/usb_descriptor_common.h Outdated Show resolved Hide resolved
@tzarc
Copy link
Member Author

tzarc commented Apr 28, 2020

What's the use case for this?

Purely configurability -- I had thought about this a while back when considering dual-bank flash and being able to flash the kb while the keyboard is active -- at the time it seemed like it might be safer to have a separate usage page. Not planning to do the flashing now, but figured the configurability might be useful.

@tzarc tzarc requested a review from a team April 28, 2020 19:21
@tzarc tzarc added the awaiting_pr Relies on another PR to be merged first label Apr 28, 2020
@tzarc tzarc marked this pull request as draft April 28, 2020 19:23
@tzarc
Copy link
Member Author

tzarc commented Apr 28, 2020

Will wait for the RAW HID doco PR #7640 to go through, first.

@tzarc tzarc force-pushed the customisable_raw branch from 679372c to ee1d56c Compare May 20, 2020 02:57
@tzarc tzarc marked this pull request as ready for review May 20, 2020 03:04
@tzarc tzarc removed the awaiting_pr Relies on another PR to be merged first label May 20, 2020
@tzarc tzarc merged commit d1df576 into qmk:master May 21, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
Gentoli added a commit to Gentoli/qmk_firmware that referenced this pull request Jul 24, 2020
@tzarc tzarc deleted the customisable_raw branch September 10, 2020 02:28
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Allow for overriding RAW endpoint usage page and ID.

* Move usb_descriptor_common.h.

* Docs update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants