-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uni660rev2 added #8807
uni660rev2 added #8807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given keyboards/sirius/uni660/rev2/rev2.h
contains both iso and ansi layout macros, the keymap folders keyboards/sirius/uni660/rev2/iso/keymaps
and keyboards/sirius/uni660/rev2/ansi/keymaps
should be merged to keyboards/sirius/uni660/rev2/keymaps
which means updates to readme and such.
@zvecr if I understand how Via reads keymaps correctly, and the fact that the ISO and ANSI PCBs are wired differently rather than just a layout change, we need a separate Via keymap directory for each, correct? That would prevent having a unified keymap directory for rev2. |
In which case, However looking at your LAYOUT macros, you can also go with my original suggestion, one via keymap and use the via layout options to switch between iso and ansi. |
The suggested changes have been made |
Thanks! |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist