Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Xd75 and viterbi keymaps, refactored my userspace. #8776

Merged
merged 25 commits into from
Apr 28, 2020
Merged

Added Xd75 and viterbi keymaps, refactored my userspace. #8776

merged 25 commits into from
Apr 28, 2020

Conversation

EricGebhart
Copy link
Contributor

Description

Added keymaps for the xd75 and viterbi keyboards.
Refactored my user space and updated my ergodox_ez keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None
*

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    t

zvecr
zvecr requested changes Apr 13, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid changing core and keyboard level code (and if changes are required, they should be PRed separately).

keyboards/xd75/keymaps/ericgebhart/rules.mk Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/ericgebhart/rules2.mk Outdated Show resolved Hide resolved
quantum/quantum.c Outdated Show resolved Hide resolved
quantum/quantum.h Outdated Show resolved Hide resolved
tmk_core/common/action_tapping.h Outdated Show resolved Hide resolved
keyboards/keebio/viterbi/rules.mk Outdated Show resolved Hide resolved
keyboards/keebio/viterbi/config.h Outdated Show resolved Hide resolved
@zvecr zvecr added the keymap label Apr 13, 2020
@zvecr zvecr requested a review from a team April 13, 2020 02:31
@EricGebhart
Copy link
Contributor Author

Oops. Sorry about that. Ithat was unintentional.

@EricGebhart
Copy link
Contributor Author

Ok. Sorry about that. Took me a couple of tries to get everything reverted.

zvecr
zvecr requested changes Apr 13, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your header files really should have #pragma once at the beginning.

keyboards/keebio/viterbi/keymaps/ericgebhart/rules.mk Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/ericgebhart/rules.mk Outdated Show resolved Hide resolved
keyboards/xd75/keymaps/ericgebhart/rules2.mk Outdated Show resolved Hide resolved
users/ericgebhart/core_keys.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team April 13, 2020 23:31
@EricGebhart
Copy link
Contributor Author

Ok. Let me know if there is anything else.

@EricGebhart
Copy link
Contributor Author

I have seen this failure before, but I cannot reproduce it with the code in my branch.

I would think it comes from not having tap_dance turned on. But it is set to yes in all of my keyboard's rules.mk. I cannot explain it.

@EricGebhart
Copy link
Contributor Author

Travis is still failing and I still cannot reproduce the error.

@EricGebhart
Copy link
Contributor Author

@zvecr let me know what I can do to resolve this, I still cannot reproduce the error that Travis is having.
It only started after the changes you requested, which makes no sense to me.

@zvecr zvecr requested review from a team and drashna April 25, 2020 23:08
@drashna drashna merged commit 485a0b0 into qmk:master Apr 28, 2020
@EricGebhart
Copy link
Contributor Author

Thank you ! I appreciate your work here.

violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@EricGebhart @violet-fish
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
731d008 
…#8776)
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@EricGebhart @lorenzoernesto
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
123bec5 
…#8776)
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@EricGebhart @sowbug
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
45ae393 
…#8776)
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@EricGebhart @turky
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
9761117 
…#8776)
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@EricGebhart @jakobaa
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
d30d633 
…#8776)
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@EricGebhart @sjmacneil
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
37e1abc 
…#8776)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@EricGebhart
[Keymap] Added Xd75 and viterbi keymaps,refactored my userspace. (qmk…
d43a820 
…#8776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricGebhart @fauxpark @drashna @zvecr