Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of confusion-inducing documentation typos #8767

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Fix a couple of confusion-inducing documentation typos #8767

merged 1 commit into from
Apr 12, 2020

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Apr 12, 2020

Description

I was reading Useful Functions - (OLKB) Tri Layers and was having a hard time understanding update_tri_layer(x, y, z) until I actually went and read the code implementing the function.

This change just fixes a couple of typos that I think will help folks to understand this more readily.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ridingqwerty
ridingqwerty approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tzarc tzarc merged commit 750179e into qmk:master Apr 12, 2020
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@spidey3 @Quarren42
Fix a couple of typos that were causing confusion (qmk#8767)
ee6cfbb
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@spidey3 @kujawakk
Fix a couple of typos that were causing confusion (qmk#8767)
6c1f2c8
@spidey3 spidey3 mentioned this pull request May 1, 2020
Closed
13 tasks
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@spidey3 @violet-fish
Fix a couple of typos that were causing confusion (qmk#8767)
80831b6
@spidey3 spidey3 deleted the doc_fix_20200411 branch May 11, 2020 19:53
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@spidey3 @lorenzoernesto
Fix a couple of typos that were causing confusion (qmk#8767)
e56d6e4
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@spidey3 @sowbug
Fix a couple of typos that were causing confusion (qmk#8767)
5486cc0
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@spidey3 @turky
Fix a couple of typos that were causing confusion (qmk#8767)
6bd7828
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@spidey3 @jakobaa
Fix a couple of typos that were causing confusion (qmk#8767)
b616454
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@spidey3
Fix a couple of typos that were causing confusion (qmk#8767)
a5af23c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spidey3 @fauxpark @ridingqwerty @tzarc