Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to blink lighting layer for a specified duration #8760

Merged
merged 9 commits into from
May 9, 2020
Merged

Add ability to blink lighting layer for a specified duration #8760

merged 9 commits into from
May 9, 2020

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Apr 11, 2020 •
edited
Loading

Description

This change adds optional functionality to allow blinking an RGB Lighting Layer on for a specified number of milliseconds. The purpose is to make it easy to use a lighting layer to acknowledge events (e.g. a settings change).

To use this new code, it must be enabled using #define RGBLIGHT_LAYER_BLINK e.g. in your config.h.

Kudos to @n8gray for the great RGBLight layers implementation. It is my hope that this small addition will make it even more useful!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Apr 13, 2020
View reviewed changes
docs/feature_rgblight.md Outdated Show resolved Hide resolved
@spidey3 spidey3 requested a review from drashna April 13, 2020 14:41
@drashna
Copy link
Member

drashna commented Apr 19, 2020

Could you pul out the user code, here?

Otherwise, LGTM.

@drashna drashna requested a review from a team April 19, 2020 00:28
@spidey3
Copy link
Contributor Author

spidey3 commented Apr 19, 2020

Could you pul out the user code, here?

Done.

@drashna drashna requested a review from a team April 28, 2020 09:43
@spidey3
Copy link
Contributor Author

spidey3 commented May 2, 2020

Gentle ping...

noroadsleft
noroadsleft requested changes May 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run qmk cformat quantum/rgblight.c quantum/rgblight.h and commit the changes it gives?

Other than that and the notes below, looks good to me.

docs/feature_rgblight.md Outdated Show resolved Hide resolved
docs/feature_rgblight.md Outdated Show resolved Hide resolved
docs/feature_rgblight.md Outdated Show resolved Hide resolved
@spidey3
Copy link
Contributor Author

spidey3 commented May 7, 2020

Could you please run qmk cformat quantum/rgblight.c quantum/rgblight.h and commit the changes it gives?

Done.

@spidey3 spidey3 requested a review from noroadsleft May 7, 2020 12:08
noroadsleft
noroadsleft approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team May 7, 2020 19:10
@drashna drashna merged commit e0f5480 into qmk:master May 9, 2020
@spidey3 spidey3 deleted the blink_rgb_layer branch May 11, 2020 19:54
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@spidey3 @noroadsleft @lorenzoernesto
Add ability to blink lighting layer for a specified duration (qmk#8760)
60c1b98 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@spidey3 @noroadsleft @drashna
Add ability to blink lighting layer for a specified duration (qmk#8760)
357ffca 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@spidey3 @noroadsleft @sowbug
Add ability to blink lighting layer for a specified duration (qmk#8760)
e9f4000 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@spidey3 @noroadsleft @fdidron
Add ability to blink lighting layer for a specified duration (qmk#8760)
d487e0f 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@spidey3 @noroadsleft @turky
Add ability to blink lighting layer for a specified duration (qmk#8760)
bf38bef 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@spidey3 @noroadsleft @jakobaa
Add ability to blink lighting layer for a specified duration (qmk#8760)
63afd04 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@spidey3 @noroadsleft @sjmacneil
Add ability to blink lighting layer for a specified duration (qmk#8760)
3fd8308 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@spidey3 @noroadsleft
Add ability to blink lighting layer for a specified duration (qmk#8760)
87bdb80 
* Implement momentarily blink of lighting layers

* Refactor spidey3 userspace to use rgb layer blink

* Remove un-necessary line from example in documentation

* Revert "Refactor spidey3 userspace to use rgb layer blink"

This reverts commit 831649b.

* Adds a missing bit of documentation about lighting layer blink

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* Update docs/feature_rgblight.md per suggestions

Co-authored-by: James Young <[email protected]>

* cformat, as suggested

Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spidey3 @drashna @fauxpark @noroadsleft