Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom layout for KBDFans KBD67 rev2 #8752

Merged
merged 7 commits into from
Apr 15, 2020
Merged

Added custom layout for KBDFans KBD67 rev2 #8752

merged 7 commits into from
Apr 15, 2020

Conversation

jscatena88
Copy link
Contributor

Description

My custom layout for the KBD67 rev2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keymap label Apr 11, 2020
@zvecr zvecr requested a review from a team April 11, 2020 02:32
jscatena88
jscatena88 commented Apr 13, 2020
View reviewed changes
Copy link
Contributor Author

@jscatena88 jscatena88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed suggestions

@zvecr zvecr requested a review from fauxpark April 13, 2020 22:53
@noroadsleft noroadsleft merged commit 5185c52 into qmk:master Apr 15, 2020
@noroadsleft
Copy link
Member

Thanks!

Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@jscatena88 @Quarren42
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
a2f88a4 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
@jscatena88 jscatena88 deleted the tofu65_layout branch April 15, 2020 15:35
galactic1969 added a commit to galactic1969/qmk_firmware that referenced this pull request Apr 16, 2020
@galactic1969
Merge remote-tracking branch 'upstream/master'
6a9d5c0 
* upstream/master: (1967 commits)
  [Docs] Japanese translation of docs/feature_combo.md (qmk#8671)
  Remove old setup scripts (qmk#8811)
  [Keyboard] ProjectKB Alice rev2 (qmk#8718)
  MILC: Fix setting config values for store_true and store_false (qmk#8813)
  KC60 Refactor (qmk#8782)
  Fix quick7 build command (qmk#8812)
  Miscellaneous stuff: remove clang-complete and autocomplete.sh, fix some rules.mk comments (qmk#8784)
  [Keyboard] add new keyboard quick7 (qmk#8670)
  [Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
  [keyboard] Add kudox rev3 (qmk#8704)
  CLI: Fix doctor error when can't run `bin/qmk --version`. (qmk#8796)
  deleted unused keymap (qmk#8797)
  Add missing repository name to qmk setup w/ github (qmk#8792)
  Configure RGBLIGHT_SPLIT for Mint60 (qmk#8788)
  [Keyboard] Aplx6 (qmk#8727)
  update pvinis keymap (qmk#8746)
  CLI: Use `shutil.which` to detect gmake, instead of OS check.
  CLI: Invoke gmake on FreeBSD when using `qmk compile`.
  [Docs] Japanese translation of docs/feature_dip_switch.md (qmk#8673)
  Fix broken KBD8X MKII Hardware link (qmk#8787)
  ...
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@jscatena88 @kujawakk
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
af7c301 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@jscatena88 @violet-fish
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
ff05880 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@jscatena88 @lorenzoernesto
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
186d959 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@jscatena88 @sowbug
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
531f1db 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@jscatena88 @turky
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
c453af0 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@jscatena88 @jakobaa
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
7a9f1a5 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@jscatena88 @sjmacneil
[Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
1600fa4 
* added v1 of keyboard layout

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Update keyboards/kbdfans/kbd67/rev2/keymaps/jscatena88/keymap.c

* Delete config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jscatena88 @noroadsleft @fauxpark @zvecr