Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layers from getting stuck on the Kyria default layout #8736

Closed
wants to merge 5 commits into from

Conversation

splitkb
Copy link
Contributor

@splitkb splitkb commented Apr 8, 2020

Description

The Lower layer kept getting stuck. This turned out to be an error on my side while developing the keymap. I've fixed the layout, and now layers aren't getting stuck anymore.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Apr 8, 2020

Is this a recent thing? One that looks like #8693 will fix.

@zvecr zvecr added the keymap label Apr 8, 2020
@zvecr zvecr requested a review from a team April 8, 2020 22:35
@splitkb
Copy link
Contributor Author

splitkb commented Apr 8, 2020

I recall seeing the behaviour about three to four weeks back, possibly longer, I hadn't taken the time to fix it yet.

@drashna
Copy link
Member

drashna commented Apr 12, 2020

I recall seeing the behaviour about three to four weeks back, possibly longer, I hadn't taken the time to fix it yet.

The bug that introduced this (#4892, 5117dff) was committed march 22nd, so that sounds about right for the timing.

And looking at the keymap, these are LT keycodes. So this should be fixed by updating the repo.

@drashna
Copy link
Member

drashna commented Apr 19, 2020

@splitkb Is it okay if we close this? The issue this code change attempts to fix has been addressed already, and shouldn't be needed.

@splitkb
Copy link
Contributor Author

splitkb commented Apr 20, 2020

@drashna If it's not needed then it can be closed, thank you for looking into it.

@zvecr zvecr closed this Apr 25, 2020
@zvecr
Copy link
Member

zvecr commented Apr 25, 2020

"shouldn't be needed" + "If it's not needed then it can be closed" == closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants