Keymap update - massdrop/ctrl/responsive_pattern #8730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n respopnse to the last update (qmk#5328)
valen214
changed the title
|
Thank you for your contribution! |
drashna
approved these changes
Jun 18, 2020
tzarc
approved these changes
Jul 25, 2020
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* rewrite keyboards/massdrop/ctrl/keymaps/responsive_pattern/keymap.c in respopnse to the last update (qmk#5328) * remove print.h * changed default parameters, modified readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"responsive pattern"add splash led effect to massdrop CTRL keyboardTypes of Changes
last rgb matrix update (#5328) broke the old code,
this update utilizes the newly added
led_instructionsfor led rgb effectbackground led are also affected now!
Issues Fixed or Closed by This PR
Checklist
Extra
for now only traveling splash is implemented, other effects provided in the past (single key twinkle, pattern indicators on the number row, background-off-key-on) might be added in the not-so-near future, same applies to documentation (README).