Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboad firmware treadstone48rev2 #8719

Merged
merged 35 commits into from
May 7, 2020
Merged

Add keyboad firmware treadstone48rev2 #8719

merged 35 commits into from
May 7, 2020

Conversation

marksard
Copy link
Contributor

@marksard marksard commented Apr 7, 2020

I want add keyboad firmware for treadstone48 rev2

Description

I updated the Treadstone48 PCB. Therefore it need for update firmware.
Update point is below.

  • Remove numpad connection (Therefore, I think better I move the keymap that only rev1 supports.)
  • Change key layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

marksard and others added 28 commits March 14, 2019 17:23
@marksard
Keyboard: add treeadstone48
9aa9a35
@marksard
rename layout defines
ed5ccb5
@marksard
Use of pragma once
e2a6758
@marksard
move common include code
5aab7cf
@marksard
fixed info.json
8ef4206
@marksard
change keymap layout from kc to normal
5f505d2
@marksard
fix alpha revision keymap
f2c1aa6
@marksard
fixed info.json
c23830a
remove USE_Link_Time_Optimization
7faf482
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
23a1e4a 
# Conflicts:
#	keyboards/treadstone48/rev1/config.h
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
b56193d
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
7f84a12
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
cbfe43b
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
fcfaea7
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
0ec5ecf
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
df263c0
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
d4be967
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
73ef338
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
3f3127f
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
89e6bd7
@marksard
Merge branch 'master' of https://github.com/marksard/qmk_firmware
4f01df2
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
57f8068
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
f87c8fd
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
6e0a7c0
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
b7a5916
@marksard
Merge branch 'master' of https://github.com/qmk/qmk_firmware
ba4c498
@marksard
Add keyboard firmware of treadstone48 rev.2
d829110
@marksard
move the rev1-supported keymap.
49c7962
drashna
drashna requested changes Apr 12, 2020
View reviewed changes
keyboards/treadstone48/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev2/rev2.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 19, 2020 00:09
fauxpark
fauxpark requested changes Apr 19, 2020
View reviewed changes
keyboards/treadstone48/rev2/rev2.h Outdated Show resolved Hide resolved
@marksard marksard requested a review from fauxpark April 23, 2020 07:45
@marksard
Copy link
Contributor Author

Any other changes?

@marksard
Copy link
Contributor Author

marksard commented May 5, 2020

Could you tell me why this PR is never end?

noroadsleft
noroadsleft requested changes May 7, 2020
View reviewed changes
keyboards/treadstone48/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev2/rev2.h Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 8e56d10 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@marksard @brandonschlack
[Keyboard] treadstone48/rev2 (qmk#8719)
41e1956 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
myuhe pushed a commit to myuhe/qmk_firmware that referenced this pull request May 8, 2020
@marksard @myuhe
[Keyboard] treadstone48/rev2 (qmk#8719)
c0a66e4 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@marksard @lorenzoernesto
[Keyboard] treadstone48/rev2 (qmk#8719)
850cf4c 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@marksard @sowbug
[Keyboard] treadstone48/rev2 (qmk#8719)
1c91720 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@marksard @turky
[Keyboard] treadstone48/rev2 (qmk#8719)
07a77ad 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@marksard @jakobaa
[Keyboard] treadstone48/rev2 (qmk#8719)
692658b 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
@marksard marksard deleted the add_keyboad_firmware_treadstone48rev2 branch July 12, 2020 05:49
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@marksard @sjmacneil
[Keyboard] treadstone48/rev2 (qmk#8719)
7be9587 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization

* Add keyboard firmware of treadstone48 rev.2

* move the rev1-supported keymap.

* layout code was updated by review

* remove comment bar

* remove LTO ifded

* Update keyboards/treadstone48/rev2/rev2.h

* Update keyboards/treadstone48/rev2/rev2.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marksard @noroadsleft @drashna @fauxpark