Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LB75 keyboard #8607

Merged
merged 26 commits into from
May 7, 2020
Merged

Add LB75 keyboard #8607

merged 26 commits into from
May 7, 2020

Conversation

ai03-2725
Copy link
Contributor

Description

Adds support for the LB75

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds support for LB75

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei added the keyboard label Mar 30, 2020
ridingqwerty
ridingqwerty requested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few formatting suggestions as tabs are throwing off the keymap alignment.

Looks good otherwise.

keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
drashna
drashna requested changes Mar 31, 2020
View reviewed changes
keyboards/quad_h/lb75/lb75.c Outdated Show resolved Hide resolved
ai03 and others added 2 commits April 1, 2020 16:38
@drashna drashna requested review from a team and noroadsleft April 5, 2020 08:11
fauxpark
fauxpark requested changes Apr 5, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This board is missing a default keymap.

keyboards/quad_h/lb75/readme.md Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/readme.md Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c Outdated Show resolved Hide resolved
ai03 and others added 8 commits April 20, 2020 17:57
@fauxpark
Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c
ac8fec1 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/readme.md
7d4d12f 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/keymaps/via/keymap.c
e0c470d 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c
3f726f7 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c
5be346f 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c
cb51315 
Co-Authored-By: Ryan <[email protected]>
@fauxpark
Update keyboards/quad_h/lb75/keymaps/via/keymap.c
90c9e75 
Co-Authored-By: Ryan <[email protected]>
@ai03-2725
Add default keymap as required
4faedf7
@zvecr zvecr requested a review from ridingqwerty April 20, 2020 09:46
@zvecr zvecr requested a review from fauxpark April 20, 2020 09:46
@ai03-2725 ai03-2725 mentioned this pull request Apr 25, 2020
Merged
6 tasks
noroadsleft
noroadsleft requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The continuous_fnrow keymap could also be deleted, since it's the same as default. Excluding that and the issues flagged below, everything looks good.

keyboards/quad_h/lb75/info.json Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/info.json Show resolved Hide resolved
keyboards/quad_h/lb75/readme.md Outdated Show resolved Hide resolved
keyboards/quad_h/lb75/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from noroadsleft May 4, 2020 22:12
@noroadsleft noroadsleft merged commit 6064386 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@brandonschlack
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
03cf479 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@lorenzoernesto
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
802e588 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@sowbug
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
d8cf0cc 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@turky
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
96a5448 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@jakobaa
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
5faf5c3 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@sjmacneil
[Keyboard] Add QUAD-H LB75 keyboard (qmk#8607)
8734777 
* Copy back old files from 9 months ago

* Delete unnecessary functions in lb75.c

* Remove LCD and MIDI config

* Modernize ancient files

* Update keymaps as necessary

* Move files to vendor folder

* Update readme to reflect changes

* Modernize makefile

* Remove split config

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/lb75.c

* Update lb75.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Update keyboards/quad_h/lb75/keymaps/continuous_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/divided_fnrow/keymap.c

* Update keyboards/quad_h/lb75/keymaps/via/keymap.c

* Add default keymap as required

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/info.json

* Update keyboards/quad_h/lb75/readme.md

* Update keyboards/quad_h/lb75/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ai03-2725 @noroadsleft @drashna @fauxpark @ridingqwerty @mtei