Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xd002 support #8598

Merged
merged 4 commits into from
May 1, 2020
Merged

Add xd002 support #8598

merged 4 commits into from
May 1, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 29, 2020 •
edited
Loading

Description

Now with all the prerequisites merged, we can finally add some form of support.

Future TODOs

  • core bootloader support?
  • save more space (eg bootloader code has "unused" func with eats 90 bytes)

Notes

With bootloader, 6.12k firmware space

Bare minimum

Checking file size of xd002_default.hex                                                             [OK]
 * The firmware size is fine - 4014/6330 (63%, 2316 bytes free)

Not enough space for...lots of stuff

  • rgblight RGBLIGHT_ANIMATIONS

As a general rule, you can enable one of the following

  • extra
  • mouse
  • tap/hold
  • tap dance
  • basic rgblight (a single animation might fit)
  • layers

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Mar 30, 2020
View reviewed changes
keyboards/xd002/README.md Outdated Show resolved Hide resolved
@zvecr zvecr force-pushed the feature/xd002 branch 4 times, most recently from 638850c to 7d843ec Compare March 31, 2020 02:57
This was referenced Mar 31, 2020
Merged
Merged
Merged
Closed
Merged
@zvecr zvecr force-pushed the feature/xd002 branch 4 times, most recently from ed88330 to cdcb2f1 Compare April 2, 2020 21:28
@zvecr zvecr force-pushed the feature/xd002 branch 3 times, most recently from e551f62 to f7f42dd Compare April 20, 2020 19:33
@zvecr zvecr marked this pull request as ready for review April 28, 2020 23:25
@zvecr zvecr requested review from a team and drashna April 28, 2020 23:31
Erovia
Erovia reviewed Apr 29, 2020
View reviewed changes
keyboards/xd002/info.json Outdated Show resolved Hide resolved
Erovia
Erovia reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fun.

@zvecr zvecr changed the title [WIP] Add xd002 support Add xd002 support May 1, 2020
@zvecr zvecr merged commit f7324ec into qmk:master May 1, 2020
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@zvecr @Erovia @violet-fish
Add xd002 support (qmk#8598)
87e7676 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@zvecr @Erovia @lorenzoernesto
Add xd002 support (qmk#8598)
128b5ab 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@zvecr @Erovia @sowbug
Add xd002 support (qmk#8598)
f00aa27 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@zvecr @Erovia @turky
Add xd002 support (qmk#8598)
fa2c3bd 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@zvecr @Erovia @jakobaa
Add xd002 support (qmk#8598)
d07a019 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@zvecr @Erovia @sjmacneil
Add xd002 support (qmk#8598)
b7a9247 
* Add xd002 support

* tidy some whitespace

* align filename

* Update keyboards/xd002/info.json

Co-authored-by: Erovia <[email protected]>

Co-authored-by: Erovia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia left review comments

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[discussion] XD-002, a cool, new, but attiny85 2% keyboard
4 participants
@zvecr @drashna @Erovia @fauxpark