Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Shambles TKL #8500

Merged
merged 14 commits into from
May 9, 2020
Merged

Add support for Shambles TKL #8500

merged 14 commits into from
May 9, 2020

Conversation

OsciX
Copy link
Contributor

@OsciX OsciX commented Mar 20, 2020

Description

Added support for a new minimalist keyboard, the Shambles TKL.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than a number of formatting/convention changes

keyboards/shambles/config.h Outdated Show resolved Hide resolved
keyboards/shambles/config.h Outdated Show resolved Hide resolved
keyboards/shambles/rules.mk Outdated Show resolved Hide resolved
keyboards/shambles/rules.mk Outdated Show resolved Hide resolved
keyboards/shambles/shambles.h Outdated Show resolved Hide resolved
keyboards/shambles/shambles.h Outdated Show resolved Hide resolved
keyboards/shambles/shambles.h Outdated Show resolved Hide resolved
keyboards/shambles/config.h Outdated Show resolved Hide resolved
keyboards/shambles/config.h Outdated Show resolved Hide resolved
@OsciX
Copy link
Contributor Author

OsciX commented Mar 21, 2020

Alright, changes added.

@OsciX OsciX requested a review from drashna March 21, 2020 20:11
noroadsleft
noroadsleft requested changes Mar 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd very much appreciate:

keyboards/shambles/config.h Outdated Show resolved Hide resolved
keyboards/shambles/config.h Outdated Show resolved Hide resolved
keyboards/shambles/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/shambles/rules.mk Outdated Show resolved Hide resolved
keyboards/shambles/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 23, 2020 00:21
@OsciX
Copy link
Contributor Author

OsciX commented May 6, 2020

I'd very much appreciate:

* a readme per the [QMK template](https://github.com/qmk/qmk_firmware/blob/d511e52c1f84b439e85c8f9408716c28dcf9c1d0/quantum/template/avr/readme.md)

* an [`info.json` for QMK Configurator](https://docs.qmk.fm/#/reference_info_json)

Added to pull request.

@zvecr zvecr requested a review from noroadsleft May 6, 2020 23:01
noroadsleft
noroadsleft requested changes May 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change. Everything else looks good.

keyboards/shambles/readme.md Outdated Show resolved Hide resolved
@OsciX OsciX requested a review from noroadsleft May 7, 2020 20:15
@noroadsleft noroadsleft merged commit cd0edbb into qmk:master May 9, 2020
@noroadsleft
Copy link
Member

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for your contribution!

bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@OsciX @lorenzoernesto
[Keyboard] Shambles TKL (qmk#8500)
6756964 
* Add support for the Shambles TKL

* Fix Shambles files

* Add files via upload

* Fix Shambles again

* Delete shambles.h.h

* Delete shambles.c.c

* Add files via upload

* Delete Makefile

* Apply suggestions from code review

* Fix default layout to work with review

* Apply suggestions from code review

* Add info files

* Update readme.md

* Update keyboards/shambles/readme.md
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@OsciX @sowbug
[Keyboard] Shambles TKL (qmk#8500)
de05301 
* Add support for the Shambles TKL

* Fix Shambles files

* Add files via upload

* Fix Shambles again

* Delete shambles.h.h

* Delete shambles.c.c

* Add files via upload

* Delete Makefile

* Apply suggestions from code review

* Fix default layout to work with review

* Apply suggestions from code review

* Add info files

* Update readme.md

* Update keyboards/shambles/readme.md
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@OsciX @turky
[Keyboard] Shambles TKL (qmk#8500)
1f77663 
* Add support for the Shambles TKL

* Fix Shambles files

* Add files via upload

* Fix Shambles again

* Delete shambles.h.h

* Delete shambles.c.c

* Add files via upload

* Delete Makefile

* Apply suggestions from code review

* Fix default layout to work with review

* Apply suggestions from code review

* Add info files

* Update readme.md

* Update keyboards/shambles/readme.md
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@OsciX @jakobaa
[Keyboard] Shambles TKL (qmk#8500)
7ec5f86 
* Add support for the Shambles TKL

* Fix Shambles files

* Add files via upload

* Fix Shambles again

* Delete shambles.h.h

* Delete shambles.c.c

* Add files via upload

* Delete Makefile

* Apply suggestions from code review

* Fix default layout to work with review

* Apply suggestions from code review

* Add info files

* Update readme.md

* Update keyboards/shambles/readme.md
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@OsciX @sjmacneil
[Keyboard] Shambles TKL (qmk#8500)
fe7a774 
* Add support for the Shambles TKL

* Fix Shambles files

* Add files via upload

* Fix Shambles again

* Delete shambles.h.h

* Delete shambles.c.c

* Add files via upload

* Delete Makefile

* Apply suggestions from code review

* Fix default layout to work with review

* Apply suggestions from code review

* Add info files

* Update readme.md

* Update keyboards/shambles/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OsciX @noroadsleft @drashna @zvecr @Erovia