Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add basic json keymap support #8498

Closed
wants to merge 3 commits into from
Closed

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Mar 20, 2020

Description

This intends to be a groundwork for better/more json keymap integration.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia requested review from skullydazed and a team March 20, 2020 11:40
@tzarc tzarc requested a review from a team March 22, 2020 09:16
@skullydazed
Copy link
Member

To document what we talked about on discord a few days ago, I would like to see this done as part of a usecase rather than add it on its own without features to hang on it.

@Erovia Erovia mentioned this pull request Apr 15, 2020
13 tasks
@Erovia Erovia closed this Apr 17, 2020
@Erovia Erovia deleted the cli_json_keymap branch April 17, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants